Messages in this thread | | | Subject | Re: [PATCH] staging: rtl8712: Fix Comparison with constant warning. | From | Larry Finger <> | Date | Sat, 6 Feb 2016 08:53:57 -0600 |
| |
On 02/06/2016 08:41 AM, Pinkesh Badjatiya wrote: > Fix Comparisons with constant on the left side of the test. > Checkpatch.pl warning. > -- > WARNING: Comparisons should place the constant on the right side of the > test > 296: FILE: ./rtl8712_cmd.c:296: > while ((0 != r8712_read32(pAdapter, IOCMD_CTRL_REG)) && > > Signed-off-by: Pinkesh Badjatiya <pinkeshbadjatiya@gmail.com> > --- > drivers/staging/rtl8712/rtl8712_cmd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
This is another case where the writers of checkpatch are forcing their ideas of style on the whole world. The problem is that if I reject your patch, it will be submitted by someone else. Thus, reluctantly
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
> > diff --git a/drivers/staging/rtl8712/rtl8712_cmd.c b/drivers/staging/rtl8712/rtl8712_cmd.c > index 9b91609..ce3f7da 100644 > --- a/drivers/staging/rtl8712/rtl8712_cmd.c > +++ b/drivers/staging/rtl8712/rtl8712_cmd.c > @@ -293,7 +293,7 @@ u8 r8712_fw_cmd(struct _adapter *pAdapter, u32 cmd) > > r8712_write32(pAdapter, IOCMD_CTRL_REG, cmd); > msleep(100); > - while ((0 != r8712_read32(pAdapter, IOCMD_CTRL_REG)) && > + while ((r8712_read32(pAdapter, IOCMD_CTRL_REG) != 0) && > (pollingcnts > 0)) { > pollingcnts--; > msleep(20); >
| |