lkml.org 
[lkml]   [2016]   [Feb]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] staging: rtl8712: Fix Comparison with constant warning.
From
Date
On 02/06/2016 08:41 AM, Pinkesh Badjatiya wrote:
> Fix Comparisons with constant on the left side of the test.
> Checkpatch.pl warning.
> --
> WARNING: Comparisons should place the constant on the right side of the
> test
> 296: FILE: ./rtl8712_cmd.c:296:
> while ((0 != r8712_read32(pAdapter, IOCMD_CTRL_REG)) &&
>
> Signed-off-by: Pinkesh Badjatiya <pinkeshbadjatiya@gmail.com>
> ---
> drivers/staging/rtl8712/rtl8712_cmd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

This is another case where the writers of checkpatch are forcing their ideas of
style on the whole world. The problem is that if I reject your patch, it will be
submitted by someone else. Thus, reluctantly

Acked-by: Larry Finger <Larry.Finger@lwfinger.net>


>
> diff --git a/drivers/staging/rtl8712/rtl8712_cmd.c b/drivers/staging/rtl8712/rtl8712_cmd.c
> index 9b91609..ce3f7da 100644
> --- a/drivers/staging/rtl8712/rtl8712_cmd.c
> +++ b/drivers/staging/rtl8712/rtl8712_cmd.c
> @@ -293,7 +293,7 @@ u8 r8712_fw_cmd(struct _adapter *pAdapter, u32 cmd)
>
> r8712_write32(pAdapter, IOCMD_CTRL_REG, cmd);
> msleep(100);
> - while ((0 != r8712_read32(pAdapter, IOCMD_CTRL_REG)) &&
> + while ((r8712_read32(pAdapter, IOCMD_CTRL_REG) != 0) &&
> (pollingcnts > 0)) {
> pollingcnts--;
> msleep(20);
>

\
 
 \ /
  Last update: 2016-02-06 16:21    [W:0.108 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site