| Date | Fri, 5 Feb 2016 12:39:17 +0530 | From | Viresh Kumar <> | Subject | Re: [PATCH v2 3/10] cpufreq: governor: Avoid passing dbs_data pointers around unnecessarily |
| |
On 05-02-16, 03:15, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > > Do not pass struct dbs_data pointers to the family of functions > implementing governor operations in cpufreq_governor.c as they can > take that pointer from policy->governor by themselves. > > The cpufreq_governor_init() case is slightly more complicated, since > policy->governor may be NULL when it is invoked, but then it can reach > the pointer in question via its cdata argument just fine. > > While at it, rework cpufreq_governor_dbs() to avoid a pointless > policy_governor check in the CPUFREQ_GOV_POLICY_INIT case. > > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > --- > drivers/cpufreq/cpufreq_governor.c | 68 ++++++++++++++----------------------- > 1 file changed, 27 insertions(+), 41 deletions(-)
Took some time to review, but it looks nice cleanup :)
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
-- viresh
|