lkml.org 
[lkml]   [2016]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.2.y-ckt 62/64] perf annotate browser: Fix behaviour of Shift-Tab with nothing focussed
    Date
    4.2.8-ckt4 -stable review patch.  If anyone has any objections, please let me know.

    ---8<------------------------------------------------------------

    From: Markus Trippelsdorf <markus@trippelsdorf.de>

    commit d4913cbd05bab685e49c8174896e563b2487d054 upstream.

    The issue was pointed out by gcc-6's -Wmisleading-indentation.

    Signed-off-by: Markus Trippelsdorf <markus@trippelsdorf.de>
    Acked-by: Ingo Molnar <mingo@kernel.org>
    Cc: Ben Hutchings <ben@decadent.org.uk>
    Cc: Matt Fleming <matt@codeblueprint.co.uk>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Fixes: c97cf42219b7 ("perf top: Live TUI Annotation")
    Link: http://lkml.kernel.org/r/20151214154403.GB1409@x4
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    Signed-off-by: Kamal Mostafa <kamal@canonical.com>
    ---
    tools/perf/ui/browsers/annotate.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/tools/perf/ui/browsers/annotate.c b/tools/perf/ui/browsers/annotate.c
    index ebca255..197c484 100644
    --- a/tools/perf/ui/browsers/annotate.c
    +++ b/tools/perf/ui/browsers/annotate.c
    @@ -730,11 +730,11 @@ static int annotate_browser__run(struct annotate_browser *browser,
    nd = browser->curr_hot;
    break;
    case K_UNTAB:
    - if (nd != NULL)
    + if (nd != NULL) {
    nd = rb_next(nd);
    if (nd == NULL)
    nd = rb_first(&browser->entries);
    - else
    + } else
    nd = browser->curr_hot;
    break;
    case K_F1:
    --
    1.9.1
    \
     
     \ /
      Last update: 2016-02-05 00:41    [W:8.607 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site