Messages in this thread | | | Date | Wed, 3 Feb 2016 17:47:53 +0000 | From | Mark Brown <> | Subject | Re: [PATCH v4 1/2] regulator: act8945a: add regulator driver for ACT8945A |
| |
On Wed, Feb 03, 2016 at 02:33:11AM +0000, Yang, Wenyou wrote:
> > I would just remove the "active-semi,act8945a-regulator" node and make "active- > > semi,vsel-high" a property of the "active-semi,act8945a" node. > > That way you can remove the mfd cell .of_compatible and OF table in the > > regulator driver and read the "active-semi,vsel-high" using the platform device's > > parent of_node.
> > But it's better if you wait for Mark's opinions before re-spining your patches.
> Hi Mark, what is your opinions?
Like Javier says you should make your DT binding look like the DT bindings for other MFDs and not use of_compatible. [unhandled content-type:application/pgp-signature] | |