Messages in this thread | | | Date | Wed, 3 Feb 2016 17:20:29 +0000 | From | Mark Brown <> | Subject | Re: [PATCH 1/2] regulator: gpio: Avoid unnecessarily copying data structures in probe() |
| |
On Fri, Jan 29, 2016 at 05:25:28PM +0100, Harald Geyer wrote: > Mark Brown writes: > > On Thu, Jan 28, 2016 at 07:55:17PM +0000, Harald Geyer wrote: > > > The data structures either have been copied in > > > of_get_gpio_regulator_config() already or are part of platform data, > > > which we keep a pointer to for the life time of the device anyway.
> > The point of this code is to avoid referring to platform data after > > probe for robustness.
> Well, if we can't rely on platform data staying available after probe() > then probably we shouldn't keep a pointer to it - but thats a different > issue, so lets focus on the original problem:
> What's your preferred way to fix the error path of probe() then?
Add the matching frees? I'm not sure I know what the original problem is mind you. [unhandled content-type:application/pgp-signature] | |