Messages in this thread | | | From | "Elliott, Robert (Persistent Memory)" <> | Subject | RE: [PATCH 14/14] x86/efi: Print size in binary units in efi_print_memmap | Date | Wed, 3 Feb 2016 15:25:24 +0000 |
| |
> -----Original Message----- > From: Matt Fleming [mailto:matt@codeblueprint.co.uk] > Sent: Wednesday, February 3, 2016 5:28 AM > To: Ingo Molnar <mingo@kernel.org> > Cc: Laszlo Ersek <lersek@redhat.com>; H . Peter Anvin <hpa@zytor.com>; > Thomas Gleixner <tglx@linutronix.de>; linux-efi@vger.kernel.org; linux- > kernel@vger.kernel.org; Elliott, Robert (Persistent Memory) > <elliott@hpe.com>; Andy Shevchenko <andriy.shevchenko@linux.intel.com>; > Ard Biesheuvel <ard.biesheuvel@linaro.org>; Taku Izumi > <izumi.taku@jp.fujitsu.com>; Linus Torvalds <torvalds@linux- > foundation.org>; Andrew Morton <akpm@linux-foundation.org> > Subject: Re: [PATCH 14/14] x86/efi: Print size in binary units in > efi_print_memmap ... > OK, this patch has caused enough headaches. Let's drop it from this > series. > > Robert, Andy, feel free to resubmit it after you've addressed > everyone's concerns and we can discuss it in isolation.
We could just delete the size print altogether - better to print nothing than a silently rounded number. The end address already communicates the size - it's just not as readable.
The e820 table prints don't bother with a size print.
That would also shorten these extremely wide prints to 116 characters (131 if printk time is enabled).
[ 0.000000] BIOS-e820: [mem 0x0000001880000000-0x000000207fffffff] reserved vs. [ 0.000000] efi: mem62: [Reserved | | |NV| | | | | |WB|WT|WC|UC] range=[0x0000001880000000-0x000000207fffffff] (32 GiB)
--- Robert Elliott, HPE Persistent Memory
| |