lkml.org 
[lkml]   [2016]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 10/14] efi: Make checkpatch complain less about efi.h GUID additions

* Matt Fleming <matt@codeblueprint.co.uk> wrote:

> On Wed, 03 Feb, at 11:50:35AM, Ingo Molnar wrote:
> >
> > Hm, so the GUIDs are line-broken in the same fashion in the spec, after the third
> > parameter?
>
> Yep, they are.
>
> > That's a strong reason indeed - and then the changelog and title should say that:
> > 're-format GUID tables to follow the format of the UEFI spec'. That it also
> > pacifies checkpatch is a side effect.
>
> I think that's a fair change.
>
> Peter could you take a look at updating the changelog in a v2? If not,
> I'll do it.

Note that I applied most of your patches to tip:efi/core, which I've just pushed
out. You might want to base v2 on that.

Thanks,

Ingo

\
 
 \ /
  Last update: 2016-02-03 12:41    [W:0.111 / U:0.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site