lkml.org 
[lkml]   [2016]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[tip:perf/core] tools build: Check basic headers for test-compile feature checker
    Commit-ID:  cf9162c290447cdf6fca7b64dd6e2200dc52f03b
    Gitweb: http://git.kernel.org/tip/cf9162c290447cdf6fca7b64dd6e2200dc52f03b
    Author: Wang Nan <wangnan0@huawei.com>
    AuthorDate: Wed, 27 Jan 2016 11:22:22 +0000
    Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
    CommitDate: Wed, 27 Jan 2016 11:59:32 -0300

    tools build: Check basic headers for test-compile feature checker

    An i386 binary can be linked correctly even without correct headers.
    Which causes problem. For exmaple:

    $ mv /tmp/oxygen_root/usr/include/gnu/stubs-32.h{,.bak}
    $ make tools/perf
    Auto-detecting system features:
    ... dwarf: [ on ]
    [SNIP]
    GEN common-cmds.h
    CC perf-read-vdso32
    In file included from /tmp/oxygen_root/usr/include/features.h:388:0,
    from /tmp/oxygen_root/usr/include/stdio.h:27,
    from perf-read-vdso.c:1:
    /tmp/oxygen_root/usr/include/gnu/stubs.h:7:27: fatal error: gnu/stubs-32.h: No such file or directory
    # include <gnu/stubs-32.h>
    ^
    compilation terminated.
    ...

    In this patch we checks not only compiler and linker, but also basic
    headers in test-compile test case, make it fail on a platform
    lacking correct headers.

    Signed-off-by: Wang Nan <wangnan0@huawei.com>
    Acked-by: Jiri Olsa <jolsa@kernel.org>
    Cc: Li Zefan <lizefan@huawei.com>
    Link: http://lkml.kernel.org/r/1453893742-20603-1-git-send-email-wangnan0@huawei.com
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    ---
    tools/build/feature/test-compile.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/tools/build/feature/test-compile.c b/tools/build/feature/test-compile.c
    index 31dbf45..c54e655 100644
    --- a/tools/build/feature/test-compile.c
    +++ b/tools/build/feature/test-compile.c
    @@ -1,4 +1,6 @@
    +#include <stdio.h>
    int main(void)
    {
    + printf("Hello World!\n");
    return 0;
    }
    \
     
     \ /
      Last update: 2016-02-03 11:41    [W:3.953 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site