Messages in this thread | | | Date | Wed, 3 Feb 2016 15:04:29 -0800 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH v3] staging: wilc1000: fix double mutex_unlock on failure path in wilc_wlan_cleanup() |
| |
On Tue, Dec 22, 2015 at 08:39:26PM +0300, Alexey Khoroshilov wrote: > If hif_read_reg() or hif_write_reg() fail in wilc_wlan_cleanup(), > it calls release_bus() and continues execution. But it leads to double > release_bus() call that means double unlock of g_linux_wlan->hif_cs mutex. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru> > --- > drivers/staging/wilc1000/wilc_wlan.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-)
Why is this 'v3'? What changed from the other versions? Please always document it below the --- line so that we have a chance when reviewing them.
Please fix up and resend with that information.
thanks,
greg k-h
| |