Messages in this thread | | | Date | Wed, 3 Feb 2016 23:21:17 +0100 | From | Krzysztof Adamski <> | Subject | Re: [PATCH v2 2/5] dts: sun8i-h3: Add APB0 related clocks and resets |
| |
On Wed, Feb 03, 2016 at 01:35:34PM +0100, Maxime Ripard wrote: >Hi, > >On Tue, Feb 02, 2016 at 10:21:50PM +0100, Krzysztof Adamski wrote: >> APB0 is bearly mentioned in H3 User Manual and it is only setup in the >> Allwinners kernel dump for CIR. I have verified experimentally that the >> gate for R_PIO exists and works, though. There are probably other gates >> there but I don't know their order right now and I don't have access to >> their peripherals on my board to test them. >> >> Signed-off-by: Krzysztof Adamski <k@japko.eu> >> --- >> arch/arm/boot/dts/sun8i-h3.dtsi | 32 ++++++++++++++++++++++++++++++++ >> 1 file changed, 32 insertions(+) >> >> diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi b/arch/arm/boot/dts/sun8i-h3.dtsi >> index 1524130e..ce35e93 100644 >> --- a/arch/arm/boot/dts/sun8i-h3.dtsi >> +++ b/arch/arm/boot/dts/sun8i-h3.dtsi >> @@ -276,6 +276,32 @@ >> clocks = <&osc24M>, <&pll6 1>, <&pll5>; >> clock-output-names = "mbus"; >> }; >> + >> + ahb0: ahb0_clk { >> + compatible = "fixed-factor-clock"; >> + #clock-cells = <0>; >> + clock-div = <1>; >> + clock-mult = <1>; >> + clocks = <&osc24M>, <&osc32k>; >> + clock-output-names = "ahb0"; >> + }; > >I'm not sure what you mean there. The fixed factor clocks only take a >single parent, and you provided two.
True, I that's actually some stupid leftover. As mentioned in the commit message I didn't really know how the clock tree looks like here so I wanted to just pretend it's connectet to osc24M. After some experiments I think that 0x01f0140c register does not exist on H3 and I was finally (hopefully) able to understand how this clock is set up in Allwinner's code. So I changed the clock to factors clock with possible osc32k and osc24M parrents. Will send it in v3.
| |