Messages in this thread | | | From | David Howells <> | Subject | Re: [PATCH] scripts/sign-file.c: Add support for signing with a raw signature | Date | Wed, 03 Feb 2016 20:45:31 +0000 |
| |
In the patched file, I see:
if (!raw_sig) { ... }
if (!raw_sig && save_sig) { ... }
if (!raw_sig && sign_only) { ... }
Can you just merge the three into one if-statement that is conditional on !raw_sig with conditional bits inside? It might be worth moving the contents out to its own function, but it deals with sufficient of main's context that it might not actually be worthwhile.
David
| |