lkml.org 
[lkml]   [2016]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] scripts/sign-file.c: Add support for signing with a raw signature
Date
In the patched file, I see:

if (!raw_sig) {
...
}

if (!raw_sig && save_sig) {
...
}

if (!raw_sig && sign_only) {
...
}


Can you just merge the three into one if-statement that is conditional on
!raw_sig with conditional bits inside? It might be worth moving the contents
out to its own function, but it deals with sufficient of main's context that
it might not actually be worthwhile.

David

\
 
 \ /
  Last update: 2016-02-03 22:01    [W:0.196 / U:1.500 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site