lkml.org 
[lkml]   [2016]   [Feb]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5/8] drivers/pinctrl: make stm32/pinctrl-stm32f429.c explicitly non-modular
    Date
    The Kconfig currently controlling compilation of this code is:

    drivers/pinctrl/stm32/Kconfig:config PINCTRL_STM32F429
    drivers/pinctrl/stm32/Kconfig: bool "STMicroelectronics STM32F429 pin control" if COMPILE_TEST && !MACH_STM32F429

    ...meaning that it currently is not being built as a module by anyone.

    Lets remove the modular code that is essentially orphaned, so that
    when reading the driver there is no doubt it is builtin-only.

    Since module_init translates to device_initcall in the non-modular
    case, the init ordering remains unchanged with this commit.

    Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.

    We also delete the MODULE_LICENSE tag etc. since all that information
    is already contained at the top of the file in the comments.

    Cc: Linus Walleij <linus.walleij@linaro.org>
    Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
    Cc: Patrice Chotard <patrice.chotard@st.com>
    Cc: linux-gpio@vger.kernel.org
    Cc: linux-arm-kernel@lists.infradead.org
    Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
    ---
    drivers/pinctrl/stm32/pinctrl-stm32f429.c | 9 +--------
    1 file changed, 1 insertion(+), 8 deletions(-)

    diff --git a/drivers/pinctrl/stm32/pinctrl-stm32f429.c b/drivers/pinctrl/stm32/pinctrl-stm32f429.c
    index f34016b51375..e9b15dc0654b 100644
    --- a/drivers/pinctrl/stm32/pinctrl-stm32f429.c
    +++ b/drivers/pinctrl/stm32/pinctrl-stm32f429.c
    @@ -4,7 +4,6 @@
    * License terms: GNU General Public License (GPL), version 2
    */
    #include <linux/init.h>
    -#include <linux/module.h>
    #include <linux/of.h>
    #include <linux/platform_device.h>

    @@ -1576,7 +1575,6 @@ static const struct of_device_id stm32f429_pctrl_match[] = {
    },
    { }
    };
    -MODULE_DEVICE_TABLE(of, stm32f429_pctrl_match);

    static struct platform_driver stm32f429_pinctrl_driver = {
    .probe = stm32_pctl_probe,
    @@ -1590,9 +1588,4 @@ static int __init stm32f429_pinctrl_init(void)
    {
    return platform_driver_register(&stm32f429_pinctrl_driver);
    }
    -
    -module_init(stm32f429_pinctrl_init);
    -
    -MODULE_LICENSE("GPL");
    -MODULE_DESCRIPTION("STM32F429 Pinctrl Driver");
    -MODULE_AUTHOR("Maxime Coquelin <mcoquelin.stm32@gmail.com>");
    +device_initcall(stm32f429_pinctrl_init);
    --
    2.6.1
    \
     
     \ /
      Last update: 2016-02-29 22:21    [W:4.046 / U:0.684 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site