Messages in this thread | | | Date | Mon, 29 Feb 2016 14:00:57 +0100 | From | Pali Rohár <> | Subject | Re: [PATCH v4 5/5] dell-wmi: support Dell Inspiron M5110 |
| |
On Wednesday 24 February 2016 08:20:15 Michał Kępień wrote: > Similarly to Dell Vostro V131, Dell Inspiron M5110 also requires an > SMBIOS request to be issued in order for WMI events to be generated and > does not raise an i8042 interrupt when the Dell Instant Launch hotkey is > pressed. However, the event code for that hotkey on this machine is > 0xe029, so add it to the legacy keymap. > > Signed-off-by: Michał Kępień <kernel@kempniu.pl> > Tested-by: Darek Stojaczyk <darek.stojaczyk@gmail.com> > --- > drivers/platform/x86/dell-wmi.c | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c > index ffc957b5..b1479ab 100644 > --- a/drivers/platform/x86/dell-wmi.c > +++ b/drivers/platform/x86/dell-wmi.c > @@ -62,6 +62,14 @@ static int __init dmi_matched(const struct dmi_system_id *dmi) > static const struct dmi_system_id dell_wmi_smbios_list[] __initconst = { > { > .callback = dmi_matched, > + .ident = "Dell Inspiron M5110", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), > + DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron M5110"), > + }, > + }, > + { > + .callback = dmi_matched, > .ident = "Dell Vostro V131", > .matches = { > DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), > @@ -110,8 +118,11 @@ static const struct key_entry dell_wmi_legacy_keymap[] __initconst = { > > { KE_IGNORE, 0xe020, { KEY_MUTE } }, > > - /* Shortcut and audio panel keys */ > + /* Dell Instant Launch key */ > { KE_KEY, 0xe025, { KEY_PROG4 } }, > + { KE_KEY, 0xe029, { KEY_PROG4 } }, > + > + /* Audio panel key */ > { KE_IGNORE, 0xe026, { KEY_RESERVED } }, > > { KE_IGNORE, 0xe02e, { KEY_VOLUMEDOWN } },
That's better, add my Reviewed-by.
-- Pali Rohár pali.rohar@gmail.com
| |