lkml.org 
[lkml]   [2016]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v7] x86/setup: get ramdisk parameters only once

* Borislav Petkov <bp@suse.de> wrote:

> > void __init setup_arch(char **cmdline_p)
> > {
> > + struct ramdisk ramdisk = {
> > + .start_addr = get_ramdisk_image(),
> > + .size = PAGE_ALIGN(get_ramdisk_size()),
> > + .reserve_ramdisk = true
> > + };
>
> More readable:
>
> struct ramdisk ramdisk = {
> .start_addr = get_ramdisk_image(),
> .size = PAGE_ALIGN(get_ramdisk_size()),
> .reserve_ramdisk = true,
> };

So I find it highly annoying that this review feedback was done by Boris, but not
implemented in v8 :-(

I'd much have preferred fewer iterations and more careful implementation, which
would have resulted in much less time wasted on the reviewer side...

Anyway, to stop this trainwreck I've fixed this (and a few other small details)
and applied the patch, but I'd also like to point out that from now on I'll stop
accepting trivial patches from serial trivial patches contributors that are not
part of some larger, more substantial work...

Thanks,

Ingo

\
 
 \ /
  Last update: 2016-02-27 13:41    [W:0.042 / U:0.592 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site