Messages in this thread Patch in this message | | | Date | Sat, 27 Feb 2016 01:45:04 -0800 | From | tip-bot for Wang Nan <> | Subject | [tip:perf/core] perf tools: Only set filter for tracepoints events |
| |
Commit-ID: fdf14720fbd02d406ac2c1c50444774b4c7eed9a Gitweb: http://git.kernel.org/tip/fdf14720fbd02d406ac2c1c50444774b4c7eed9a Author: Wang Nan <wangnan0@huawei.com> AuthorDate: Fri, 26 Feb 2016 09:31:53 +0000 Committer: Arnaldo Carvalho de Melo <acme@redhat.com> CommitDate: Fri, 26 Feb 2016 19:50:01 -0300
perf tools: Only set filter for tracepoints events
perf_evlist__set_filter() tries to set filter to every evsel linked in the evlist. However, since filters can only be applied to tracepoints, checking type of evsel before calling perf_evsel__set_filter() would be better.
Signed-off-by: Wang Nan <wangnan0@huawei.com> Cc: Alexei Starovoitov <ast@kernel.org> Cc: Jiri Olsa <jolsa@kernel.org> Cc: Li Zefan <lizefan@huawei.com> Cc: Peter Zijlstra <peterz@infradead.org> Cc: pi3orama@163.com Link: http://lkml.kernel.org/r/1456479154-136027-6-git-send-email-wangnan0@huawei.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> --- tools/perf/util/evlist.c | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c index c42e196..86a0383 100644 --- a/tools/perf/util/evlist.c +++ b/tools/perf/util/evlist.c @@ -1223,6 +1223,9 @@ int perf_evlist__set_filter(struct perf_evlist *evlist, const char *filter) int err = 0; evlist__for_each(evlist, evsel) { + if (evsel->attr.type != PERF_TYPE_TRACEPOINT) + continue; + err = perf_evsel__set_filter(evsel, filter); if (err) break;
| |