Messages in this thread | | | Date | Fri, 26 Feb 2016 16:03:35 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [RFC] Re: [PATCH v3 1/2] tracing/syscalls: Rename variable 'nr' to '__syscall_nr' |
| |
Em Fri, Feb 26, 2016 at 01:23:01PM -0500, Steven Rostedt escreveu: > On Fri, 26 Feb 2016 10:57:13 -0300 Arnaldo Carvalho de Melo <acme@kernel.org> wrote: > > If we stand by published ABIs, we should keep it written in stone and > > state that the first 'nr' means '__syscall_nr' while keeping it as-is, > > the change for 'perf trace' in that case is to do nothing, it work > > as-is, we have just to fix the python binding to do that rename.
<SNIP>
> > Perhaps we can live with that, to avoid having three different cases: > > !nr, nr and __syscall_nr. > > We could, do this as well. Want me to add something to event-parse?
You mean do nothing in the kernel? Suits me fine, the fix would be just on the tools/perf/ code, where it generates the python skeletons, I can do that, as I guess Taeung is sleep at this point :-)
- Arnaldo
| |