Messages in this thread | | | Subject | Re: [PATCH] x86/mm: fix slow_virt_to_phys() for X86_PAE again | From | Toshi Kani <> | Date | Thu, 25 Feb 2016 10:03:10 -0700 |
| |
On Thu, 2016-02-25 at 01:58 -0800, Dexuan Cui wrote: > "d1cd12108346: x86, pageattr: Prevent overflow in slow_virt_to_phys() for > X86_PAE" > was unintentionally removed by the recent > "34437e67a672: x86/mm: Fix slow_virt_to_phys() to handle large PAT bit". > > And, the variable 'phys_addr' was defined as "unsigned long" by mistake > -- it should > be "phys_addr_t". > > As a result, Hyper-V network driver in 32-PAE Linux guest can't work > again. > > Fixes: "commmit 34437e67a672: x86/mm: Fix slow_virt_to_phys() to handle > large PAT bit" > Signed-off-by: Dexuan Cui <decui@microsoft.com> > Cc: Toshi Kani <toshi.kani@hpe.com> > Cc: Andrew Morton <akpm@linux-foundation.org> > Cc: Thomas Gleixner <tglx@linutronix.de> > Cc: K. Y. Srinivasan <kys@microsoft.com> > Cc: Haiyang Zhang <haiyangz@microsoft.com> > Cc: gregkh@linuxfoundation.org > Cc: linux-mm@kvack.org > Cc: olaf@aepfle.de > Cc: apw@canonical.com > Cc: jasowang@redhat.com > Cc: stable@vger.kernel.org
Thanks for the fix and adding the comment to explain the trick! The change looks good to me.
Reviewed-by: Toshi Kani <toshi.kani@hpe.com>
-Toshi
| |