Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH] ARM: sa1100: make sa1100_register_uart_fns a function | Date | Thu, 25 Feb 2016 15:34:37 +0100 |
| |
On Thursday 25 February 2016 14:18:44 Linus Walleij wrote: > On Tue, Feb 23, 2016 at 3:34 PM, Arnd Bergmann <arnd@arndb.de> wrote: > > > Calling sa1100_register_uart_fns() leaves the port structure > > unused when CONFIG_SERIAL_SA1100 is disabled, and we get a > > compiler warning about that: > > > > arch/arm/mach-sa1100/badge4.c:317:31: warning: 'badge4_port_fns' defined but not used [-Wunused-variable] > > static struct sa1100_port_fns badge4_port_fns __initdata = { > > > > This turns the two empty macros into empty inline functions, > > which has the same effect, but lets the compiler know that the > > variables are intentionally unused. > > > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > Acked-by: Linus Walleij <linus.walleij@linaro.org> > > > include/linux/platform_data/sa11x0-serial.h | 8 ++++++-- > > It looks like you should send this to Greg?
Yes, good point.
The file was traditionally under arch/arm (or include/asm-arm before that), but considering it as part of the driver makes slightly more sense now.
Sent out with a modified subject and your Ack to Greg now.
Arnd
| |