lkml.org 
[lkml]   [2016]   [Feb]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] arch/x86: convert all printk(KERN_INFO ) to pr_info()
From
Date
On Thu, 2016-02-25 at 09:22 +0100, Ingo Molnar wrote:
> * Chen Yucong <slaoub@gmail.com> wrote:
>
> > arch/x86/* use a mixture of printk(KERN_INFO ) and pr_info().
> > This patch converts all of printk(KERN_INFO ) to pr_info() for
> > arch/x86 directory.
> >
> > Signed-off-by: Chen Yucong <slaoub@gmail.com>
>
> > 85 files changed, 332 insertions(+), 394 deletions(-)
>
> So what this changelog is missing is how it was ensured that the printk output did
> not change.
>
The previously committed patch was applied to a particular directory.
This involved all printk(KERN_<LEVEL>), including `ugly` pr_debug().

However this patch are only related to printk(KERN_INFO ...), pr_info()
is less dangerous than pr_debug(). The macro body of pr_info() is
simple and definite, without any conditional options.

An theme to notice: this patch also refers to only a few pr_err(), and
if it is feasible, the next patch will covert all printk(KERN_ERR ) to
pr_err(). This might be a less risky way for conversion.

thx!
cyc

\
 
 \ /
  Last update: 2016-02-25 14:01    [W:2.390 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site