Messages in this thread | | | Subject | Re: [PATCH] arch/x86: convert all printk(KERN_INFO ) to pr_info() | From | Chen Yucong <> | Date | Thu, 25 Feb 2016 20:15:34 +0800 |
| |
On Thu, 2016-02-25 at 09:22 +0100, Ingo Molnar wrote: > * Chen Yucong <slaoub@gmail.com> wrote: > > > arch/x86/* use a mixture of printk(KERN_INFO ) and pr_info(). > > This patch converts all of printk(KERN_INFO ) to pr_info() for > > arch/x86 directory. > > > > Signed-off-by: Chen Yucong <slaoub@gmail.com> > > > 85 files changed, 332 insertions(+), 394 deletions(-) > > So what this changelog is missing is how it was ensured that the printk output did > not change. > The previously committed patch was applied to a particular directory. This involved all printk(KERN_<LEVEL>), including `ugly` pr_debug().
However this patch are only related to printk(KERN_INFO ...), pr_info() is less dangerous than pr_debug(). The macro body of pr_info() is simple and definite, without any conditional options.
An theme to notice: this patch also refers to only a few pr_err(), and if it is feasible, the next patch will covert all printk(KERN_ERR ) to pr_err(). This might be a less risky way for conversion.
thx! cyc
| |