Messages in this thread | | | Date | Wed, 24 Feb 2016 16:17:12 +0000 | From | Will Deacon <> | Subject | Re: [PATCH] thp: call pmdp_invalidate() with correct virtual address |
| |
On Wed, Feb 24, 2016 at 06:58:03PM +0300, Kirill A. Shutemov wrote: > Sebastian Ott and Gerald Schaefer reported random crashes on s390. > It was bisected to my THP refcounting patchset. > > The problem is that pmdp_invalidated() called with wrong virtual > address. It got offset up by HPAGE_PMD_SIZE by loop over ptes. > > The solution is to introduce new variable to be used in loop and don't > touch 'haddr'. > > Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com> > Reported-by: Gerald Schaefer <gerald.schaefer@de.ibm.com> > Reported-by Sebastian Ott <sebott@linux.vnet.ibm.com> > --- > mm/huge_memory.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-)
Looks good to me:
Reviewed-by: Will Deacon <will.deacon@arm.com>
Thanks,
Will
| |