Messages in this thread | | | Date | Tue, 23 Feb 2016 21:28:47 -0800 | From | Andrew Morton <> | Subject | Re: sscanf: implement basic character sets |
| |
On Wed, 24 Feb 2016 00:13:47 -0500 Jessica Yu <jeyu@redhat.com> wrote:
> >> This patch adds support for the '%[' conversion specifier for sscanf(). > >> This is useful in cases where we'd like to match substrings delimited by > >> something other than spaces. The original motivation for this patch > >> actually came from a livepatch discussion (See: https://lkml.org/lkml/2016/2/8/790), > >> where we were trying to come up with a clean way to parse symbol names with > >> substrings delimited by periods and commas. > > > > It would be better to include the justification right here in the > > changelog please. > > Not via some link-to-discussion and definitely not > > below the ^--- marker! It's very important. > > Thanks for the corrections Andrew. I am however slightly confused, are > you suggesting that I should provide a much more thorough explanation > about the motivation here in the changelog (below the ^--- marker), or > would this be better suited for a (separate) cover letter?
Just in the plain old changelog is good - if it was in [0/n] I'd only move it into the changelog anyway.
And 99.9% of the stuff people put below ^--- is useful so I always end up moving that into the changelog as well...
| |