lkml.org 
[lkml]   [2016]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC][PATCH 4/7] perf: Fix scaling vs enable_on_exec
On Wed, Feb 24, 2016 at 12:53:51PM +0100, Peter Zijlstra wrote:
> On Tue, Feb 23, 2016 at 06:47:41PM +0100, Peter Zijlstra wrote:
> > On Tue, Feb 23, 2016 at 10:05:50PM +0530, Pratyush Anand wrote:
> > > Its better with this patch, still count is 1 more in case of higher probe hits (
> > > like 65535 times).
> >
> > Ah, ok, I'll go try again.
>
> OK, so the below seems to cure this for me, but now I'm hurting my head
> to make the same true for perf_install_in_context(), because 'tricky' :/
>

FWIW, it would be nice to have a similar test for:

attr = {
.disabled = true;
}

sys_perf_event_open(&attr, .pid = self);

if (attr.disabled)
ioctl(ENABLE);

/* generate N events */

ioctl(DISABLE);

read();

/* print event cnt and scale factors */

and one that has .disabled = false.

\
 
 \ /
  Last update: 2016-02-24 15:41    [W:0.075 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site