lkml.org 
[lkml]   [2016]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v9 0/2] power: act8945a: add charger driver for the sub-device of ACT8945A MFD
Date
Hello Sebastian,

> -----Original Message-----
> From: Wenyou Yang [mailto:wenyou.yang@atmel.com]
> Sent: 2016年2月15日 16:22
> To: Sebastian Reichel <sre@kernel.org>; Dmitry Eremin-Solenikov
> <dbaryshkov@gmail.com>; David Woodhouse <dwmw2@infradead.org>; Rob
> Herring <robh+dt@kernel.org>; Pawel Moll <pawel.moll@arm.com>; Mark Brown
> <broonie@kernel.org>; Ian Campbell <ijc+devicetree@hellion.org.uk>; Kumar
> Gala <galak@codeaurora.org>
> Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>; Javier Martinez Canillas
> <javier@dowhile0.org>; Lee Jones <lee.jones@linaro.org>; Peter Korsgaard
> <jacmet@gmail.com>; Ferre, Nicolas <Nicolas.FERRE@atmel.com>; linux-arm-
> kernel@lists.infradead.org; linux-kernel@vger.kernel.org; linux-
> pm@vger.kernel.org; Yang, Wenyou <Wenyou.Yang@atmel.com>
> Subject: [PATCH v9 0/2] power: act8945a: add charger driver for the sub-device
> of ACT8945A MFD
>
> The ACT8945A is a Multi Function Device with the following subdevices:
> - Regulator
> - Charger

I would like to know if this patch set is okay to apply. Or any comments?

Thanks.

>
> This patch set is to add regulator driver for ACT8945A.
> It is based on the patch set:
> http://lists.infradead.org/pipermail/linux-arm-kernel/2016-
> February/405258.html
>
> Changes in v9:
> - add check if charger->regmap is a NULL pointer.
> - collect Reviewed-by tag.
>
> Changes in v8:
> - remove the OF table.
> - due to the mfd cell .of_compatible removal, use the platform
> device's parent of_node to read the property and assign it
> to the psy_cfg.of_node.
> - fix the typo.
> - due the mfd cell .of_compatible removal, update the compatibe
> description and example.
>
> Changes in v7:
> - use the helper dev_get_regmap(pdev->dev.parent, NULL) to get regmap.
> - remove *act8945a_dev member from struct act8945a_charger.
> - remove *psy member from struct act8945a_charger.
> - merge _parse_dt() and _charger_config() functions, remove relevent
> members from struct act8945a_charger.
> - remove unused platform_set_drvdata(pdev, charger) statement.
>
> Changes in v6:
> - change the type value to unsigned int.
>
> Changes in v5:
> - remove spare spaces after #define.
> - add OF match table.
> - collect Reviewed-by from Krzysztof.
>
> Changes in v4:
> - use spaces after #define, not tabs.
> - use BIT(n) macros to substitute (0x01 << x).
> - change dt properties with more legible name.
> - change the properties with more legible name, clearer description.
>
> Changes in v3:
> - update the file header with short version license and author line.
> - remove unused member of struct act8945a_charger, dev.
> - action due to removing the member of stuct act8945a_dev, dev.
> - remove the unnecessary print out.
> - remove the unnecessary act8945a_charger_remove().
> - fix align of the code-style.
>
> Changes in v2:
> 1./ Substitute of_property_read_bool() for of_get_property().
> 2./ Substitute devm_power_supply_register() for power_supply_register().
> 3./ Use module_platform_driver(), instead of subsys_initcall().
> 4./ Substitute MODULE_LICENSE("GPL") for MODULE_LICENSE("GPL v2").
>
> Wenyou Yang (2):
> power: act8945a: add charger driver for ACT8945A
> power: add documentation for ACT8945A's charger DT bindings
>
> .../devicetree/bindings/power/act8945a-charger.txt | 35 ++
> drivers/power/Kconfig | 7 +
> drivers/power/Makefile | 1 +
> drivers/power/act8945a_charger.c | 359 ++++++++++++++++++++
> 4 files changed, 402 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/power/act8945a-
> charger.txt
> create mode 100644 drivers/power/act8945a_charger.c
>
> --
> 1.7.9.5


Best Regards,
Wenyou Yang

\
 
 \ /
  Last update: 2016-02-24 11:21    [W:0.765 / U:0.212 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site