Messages in this thread | | | Date | Tue, 23 Feb 2016 23:37:55 +0100 | Subject | Re: [PATCH v2 2/4] Documentation: Bindings: Add STM32 DWMAC glue | From | Joachim Eastwood <> |
| |
Hi Alexandre,
You should copy 'devicetree@vger.kernel.org' on bindings doc. Adding cc here.
On 23 February 2016 at 16:10, Alexandre TORGUE <alexandre.torgue@gmail.com> wrote: > Signed-off-by: Alexandre TORGUE <alexandre.torgue@gmail.com> > > diff --git a/Documentation/devicetree/bindings/net/stm32-dwmac.txt b/Documentation/devicetree/bindings/net/stm32-dwmac.txt > new file mode 100644 > index 0000000..18734b3 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/stm32-dwmac.txt > @@ -0,0 +1,41 @@ > +STMicroelectronics STM32 / MCU DWMAC glue layer controller > + > +This file documents platform glue layer for stmmac. > +Please see stmmac.txt for the other unchanged properties. > + > +The device node has following properties. > + > +Required properties: > +- compatible: Should be "st,stm32-dwmac" to select glue, and > + "snps,dwmac-3.50a" to select IP vesrion. > +- clocks: Should contain the GMAC main clock, and tx clock > +- compatible: Should be "st,stm32-dwmac" to select glue and > + "snps,dwmac-3.50a" to select IP version. > +- clocks: Should contain the MAC main clock > +- clock-names: Should contain the clock names "stmmaceth". > +- st,syscon : Should be phandle/offset pair. The phandle to the syscon node which > + encompases the glue register, and the offset of the control register. > + > +Optional properties: > +- clocks: Could contain: > + - the tx clock, > + - the rx clock > +- clock-names: Could contain the clock names "tx-clk", "rx-clk" > + > +Example: > + > + ethernet0: dwmac@40028000 { > + device_type = "network";
What is this 'device_type = "network"' for? It seems to used in a lot of powerpc DTs, but only a couple of arm DTs.
Maybe Rob could enlighten us?
> + compatible = "st,stm32-dwmac", "snps,dwmac-3.50a"; > + status = "disabled"; > + reg = <0x40028000 0x8000>; > + reg-names = "stmmaceth"; > + interrupts = <0 61 0>, <0 62 0>; > + interrupt-names = "macirq", "eth_wake_irq"; > + clock-names = "stmmaceth", "tx-clk", "rx-clk"; > + clocks = <&rcc 0 25>, <&rcc 0 26>, <&rcc 0 27>; > + st,syscon = <&syscfg 0x4>; > + snps,pbl = <32>;
Regarding snps,pbl; using 32 here might not give you what you would except. See comment in dwmac1000_dma_init().
The driver is hard coded to use PBL4X/PBL8X mode. Just a heads up.
regards, Joachim Eastwood
| |