lkml.org 
[lkml]   [2016]   [Feb]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH V2 09/13] blk-throttle: add trace for new proporation throttle
Date
The trace log is very helpful to track bug and performance issues.

Signed-off-by: Shaohua Li <shli@fb.com>
---
block/blk-throttle.c | 9 +++++++++
1 file changed, 9 insertions(+)

diff --git a/block/blk-throttle.c b/block/blk-throttle.c
index 01ca04e..68e2598 100644
--- a/block/blk-throttle.c
+++ b/block/blk-throttle.c
@@ -1153,6 +1153,7 @@ static void tg_update_share(struct throtl_data *td, struct throtl_grp *tg)
sq->parent_sq->share * sq->acting_weight /
sq->parent_sq->children_weight,
1);
+ throtl_log(sq, "new share=%u", sq->share);
}
}

@@ -1168,6 +1169,8 @@ static void tg_update_active_time(struct throtl_grp *tg)
sq->acting_weight = sq->weight;
sq->parent_sq->children_weight += sq->acting_weight;
tg = sq_to_tg(sq);
+ throtl_log(sq, "active weight=%u parent_weight=%u",
+ sq->acting_weight, sq->parent_sq->children_weight);
}
sq = sq->parent_sq;
}
@@ -1206,6 +1209,8 @@ static void detect_inactive_cg(struct throtl_grp *tg)
sq->parent_sq->children_weight -= sq->acting_weight;
sq->acting_weight = 0;
update_share = true;
+ throtl_log(sq, "inactive weight=%u parent_weight=%u",
+ sq->weight, sq->parent_sq->children_weight);
}
}
}
@@ -1621,6 +1626,10 @@ static void __tg_set_weight(struct throtl_grp *tg, unsigned int weight)
psq->children_weight -= old_weight - weight;
tg->service_queue.acting_weight = weight;
}
+ throtl_log(&tg->service_queue, "weight=%d parent_weight=%d",
+ tg->service_queue.acting_weight,
+ tg->service_queue.parent_sq ?
+ tg->service_queue.parent_sq->children_weight : 0);

tg_update_share(tg->td, tg);
}
--
2.6.5
\
 
 \ /
  Last update: 2016-02-22 23:21    [W:0.180 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site