lkml.org 
[lkml]   [2016]   [Feb]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/4] tools lib traceevent: Implements '%' operation
On Mon, 22 Feb 2016 14:08:22 -0300
Daniel Bristot de Oliveira <bristot@redhat.com> wrote:

> The operation '%' is not implemented on event-parse.c, causing
> an error on the parse of events with '%' operation on its
> printk format. For example,
>
> # perf record -e sched:sched_deadline_yield ~/y
> Warning: [sched:sched_deadline_yield] unknown op '%'
> ....
> # perf script
> Warning: [sched:sched_deadline_yield] unknown op '%'
> y 1641 [006] 3364.109319: sched:sched_deadline_yield: \
> [FAILED TO PARSE] now=3364109314595 \
> deadline=3364139295135 runtime=19975597
>
> This patch implements the '%' operation. With this patch, we see the
> correct output:
>
> # perf record -e sched:sched_deadline_yield ~/y
> No Warning
>
> # perf script
> y 4005 [001] 4623.650978: sched:sched_deadline_yield: \
> now=4623.650974050 \
> deadline=4623.680957364 remaining_runtime=19979611
>
> Signed-off-by: Daniel Bristot de Oliveira <bristot@redhat.com>

Arnaldo,

This patch is not dependent on the rest of the series and looks like a
good general fix.

Can you pull this one into your tree, and please add my:

Reviewed-by: Steven Rostedt <rsotedt@goodmis.org>

Thanks!

-- Steve

> ---
> tools/lib/traceevent/event-parse.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c
> index c3bd294..575e751 100644
> --- a/tools/lib/traceevent/event-parse.c
> +++ b/tools/lib/traceevent/event-parse.c
> @@ -1951,6 +1951,7 @@ process_op(struct event_format *event, struct print_arg *arg, char **tok)
> strcmp(token, "*") == 0 ||
> strcmp(token, "^") == 0 ||
> strcmp(token, "/") == 0 ||
> + strcmp(token, "%") == 0 ||
> strcmp(token, "<") == 0 ||
> strcmp(token, ">") == 0 ||
> strcmp(token, "<=") == 0 ||
> @@ -3689,6 +3690,9 @@ eval_num_arg(void *data, int size, struct event_format *event, struct print_arg
> case '/':
> val = left / right;
> break;
> + case '%':
> + val = left % right;
> + break;
> case '*':
> val = left * right;
> break;

\
 
 \ /
  Last update: 2016-02-22 21:41    [W:0.529 / U:23.360 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site