Messages in this thread | | | From | "Chen, Yu C" <> | Subject | RE: [PATCH][v3] ACPI: Do not report _OSI("Darwin") when acpi_osi=!Darwin provided | Date | Mon, 22 Feb 2016 07:59:12 +0000 |
| |
> -----Original Message----- > From: Zheng, Lv > Sent: Monday, February 22, 2016 3:57 PM > To: Chen, Yu C; linux-acpi@vger.kernel.org > Cc: linux-kernel@vger.kernel.org; rjw@rjwysocki.net; lenb@kernel.org; > matthew.garrett@nebula.com; andy.shevchenko@gmail.com; Chen, Yu C > Subject: RE: [PATCH][v3] ACPI: Do not report _OSI("Darwin") when > acpi_osi=!Darwin provided > > Hi, Yu > > > From: linux-acpi-owner@vger.kernel.org [mailto:linux-acpi- > > owner@vger.kernel.org] On Behalf Of Chen Yu > > Subject: [PATCH][v3] ACPI: Do not report _OSI("Darwin") when > > acpi_osi=!Darwin provided > > > > Commit 7bc5a2bad0b8 ("ACPI: Support _OSI("Darwin") correctly") always > > reports positive value when Apple hardware queries _OSI("Darwin"). > > But sometimes the users might want to tell the hardware they don't > > need the Darwin feature, for example, users may leverage the hardware > > to power off the Thunderbolt, by appending acpi_osi=!Darwin in command > > line, thus Apple hardware regards it as an incompatible OS X system, > > hence turns off the Thunderbolt. > [Lv Zheng] > Both this patch and the original commit that is from Matthew look wrong to > me. > IMO, the feature should be done with an entirely different approach. > Without test, I'm not sure if my comment is helpful for you. > So could you let me take over to fix this issue? > Yes, sure, thanks.
yu
| |