lkml.org 
[lkml]   [2016]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
SubjectRe: [patch] sched,rt: __always_inline preemptible_lazy()
From
Date
On Mon, 2016-02-22 at 11:36 +0800, Hillf Danton wrote:
> >
> > homer: # nm kernel/sched/core.o|grep preemptible_lazy
> > 00000000000000b5 t preemptible_lazy
> >
> > echo wakeup_rt > current_tracer ==> Welcome to infinity.
> >
> > Signed-off-bx: Mike Galbraith <umgwanakikbuti@gmail.com>
> > ---
>
> Fat finger?

Yeah, my fingers don't take direction all that well.

> BTW, would you please make a better description of the
> problem this patch is trying to address/fix?

Ok, I thought it was clear what happens.

sched,rt: __always_inline preemptible_lazy()

Functions called within a notrace function must either also be
notrace or be inlined, lest recursion blow the stack.

homer: # nm kernel/sched/core.o|grep preemptible_lazy
00000000000000b5 t preemptible_lazy

echo wakeup_rt > current_tracer ==> Welcome to infinity.

Signed-off-by: Mike Galbraith <umgwanakikbuti@gmail.com>
---
kernel/sched/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -3469,7 +3469,7 @@ static void __sched notrace preempt_sche
* set by a RT task. Oterwise we try to avoid beeing scheduled out as long as
* preempt_lazy_count counter >0.
*/
-static int preemptible_lazy(void)
+static __always_inline int preemptible_lazy(void)
{
if (test_thread_flag(TIF_NEED_RESCHED))
return 1;
\
 
 \ /
  Last update: 2016-02-22 05:41    [W:0.050 / U:0.780 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site