lkml.org 
[lkml]   [2016]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/2] mmc-sdricoh_cs: Less checks in sdricoh_init_mmc() after, error detection
    Hello,

    Am Tue, 29 Dec 2015 22:02:37 +0100
    schrieb SF Markus Elfring <elfring@users.sourceforge.net>:

    > From: Markus Elfring <elfring@users.sourceforge.net>
    > Date: Tue, 29 Dec 2015 21:45:34 +0100
    >
    > This issue was detected by using the Coccinelle software.
    >
    > Two pointer checks could be repeated by the sdricoh_init_mmc()
    > function during error handling even if the relevant properties can be
    > determined for the involved variables before by source code analysis.
    >
    > * This implementation detail could be improved by adjustments
    > for jump targets according to the Linux coding style convention.
    >
    > * Drop an unnecessary initialisation for the variable "mmc" then.
    >
    > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    > ---

    Acked-by: Sascha Sommer <saschasommer@freenet.de>

    Best regards

    Sascha

    \
     
     \ /
      Last update: 2016-02-21 19:01    [W:4.030 / U:0.432 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site