lkml.org 
[lkml]   [2016]   [Feb]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v6 16/25] perf ui/stdio: Implement hierarchy output mode
    On Tue, Feb 16, 2016 at 11:08:34PM +0900, Namhyung Kim wrote:

    SNIP

    > +static int hist_entry__hierarchy_fprintf(struct hist_entry *he,
    > + struct perf_hpp *hpp,
    > + int nr_sort_key, struct hists *hists,
    > + FILE *fp)
    > +{
    > + const char *sep = symbol_conf.field_sep;
    > + struct perf_hpp_fmt *fmt;
    > + char *buf = hpp->buf;
    > + int ret, printed = 0;
    > + bool first = true;
    > +
    > + if (symbol_conf.exclude_other && !he->parent)
    > + return 0;
    > +
    > + ret = scnprintf(hpp->buf, hpp->size, "%*s", he->depth * HIERARCHY_INDENT, "");
    > + advance_hpp(hpp, ret);
    > +
    > + hists__for_each_format(he->hists, fmt) {
    > + if (perf_hpp__is_sort_entry(fmt) || perf_hpp__is_dynamic_entry(fmt))
    > + break;
    > +
    > + /*
    > + * If there's no field_sep, we still need
    > + * to display initial ' '.
    > + */
    > + if (!sep || !first) {
    > + ret = scnprintf(hpp->buf, hpp->size, "%s", sep ?: " ");
    > + advance_hpp(hpp, ret);
    > + } else
    > + first = false;
    > +
    > + if (perf_hpp__use_color() && fmt->color)
    > + ret = fmt->color(fmt, hpp, he);
    > + else
    > + ret = fmt->entry(fmt, hpp, he);
    > +
    > + advance_hpp(hpp, ret);

    there's new hist_entry__snprintf_alignment function for
    proper alignment now used in hist_entry__hierarchy_fprintf

    you might wat to use it in here as well

    jirka

    \
     
     \ /
      Last update: 2016-02-21 00:41    [W:5.497 / U:0.160 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site