Messages in this thread | | | Date | Fri, 19 Feb 2016 10:44:34 -0700 | From | Jason Gunthorpe <> | Subject | Re: [tpmdd-devel] [PATCH] tpm_crb: fix bad name pointer usage with struct resource |
| |
On Fri, Feb 19, 2016 at 05:06:06PM +0200, Jarkko Sakkinen wrote:
> Can you quickly check the two top-most patches: > > https://github.com/jsakkine/linux-tpmdd/commits/master
Drop the change to crb_map_res, the memset is not needed.
The shutdown change is probably OK for a rc fix, but it is still wrong. The shutdown has to be done inside the code after the core has removed all access to the tpm but before it has torn down so much that the driver doesn't work anymore.
Jason
| |