lkml.org 
[lkml]   [2016]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] USB: cdc_subset: only build when one driver is enabled
    From
    From: Arnd Bergmann <arnd@arndb.de>
    Date: Wed, 17 Feb 2016 23:25:11 +0100

    > This avoids a harmless randconfig warning I get when USB_NET_CDC_SUBSET
    > is enabled, but all of the more specific drivers are not:
    >
    > drivers/net/usb/cdc_subset.c:241:2: #warning You need to configure some hardware for this driver
    >
    > The current behavior is clearly intentional, giving a warning when
    > a user picks a configuration that won't do anything good. The only
    > reason for even addressing this is that I'm getting close to
    > eliminating all 'randconfig' warnings on ARM, and this came up
    > a couple of times.
    >
    > My workaround is to not even build the module when none of the
    > configurations are enable.
    >
    > Alternatively we could simply remove the #warning (nothing wrong
    > for compile-testing), turn it into a runtime warning, or
    > change the Kconfig options into a menu to hide CONFIG_USB_NET_CDC_SUBSET.
    >
    > Signed-off-by: Arnd Bergmann <arnd@arndb.de>

    Applied, thanks Arnd.

    \
     
     \ /
      Last update: 2016-02-18 22:21    [W:2.418 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site