lkml.org 
[lkml]   [2016]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] IB/rxe: fix compare_const_fl.cocci warnings
From
Date
On 2/18/2016 8:06 AM, Julia Lawall wrote:
> Move constants to the right of binary operators.
>
> Generated by: scripts/coccinelle/misc/compare_const_fl.cocci
>
> CC: Kamal Heib <kamalh@mellanox.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
> ---
>
> The constants on the right look a bit nicer. Another possibility would be
> !!.
>
> tree: https://github.com/dledford/linux.git rxe-v2
> head: bc91f3e63df667e8da8894a51149a2fc9acf0e71
> commit: 30e5584cf453cd90bbcd3ebb5f3e774c0195dd83 [30/31] IB/rxe: Add
> Soft-RoCE to kbuild and makefiles
>
> rxe_mr.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- a/drivers/staging/rdma/rxe/rxe_mr.c
> +++ b/drivers/staging/rdma/rxe/rxe_mr.c
> @@ -43,8 +43,8 @@ static u8 rxe_get_key(void)
>
> key = key << 1;
>
> - key |= (0 != (key & 0x100)) ^ (0 != (key & 0x10))
> - ^ (0 != (key & 0x80)) ^ (0 != (key & 0x40));
> + key |= ((key & 0x100) != 0) ^ ((key & 0x10) != 0)
> + ^ ((key & 0x80) != 0) ^ ((key & 0x40) != 0);
>
> key &= 0xff;
>

Thanks, applied to my rxe-v2 branch.

[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2016-02-18 18:21    [W:0.046 / U:1.760 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site