lkml.org 
[lkml]   [2016]   [Feb]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] net: cavium: liquidio: fix check for in progress flag
From
From: Colin King <colin.king@canonical.com>
Date: Fri, 5 Feb 2016 16:30:39 +0000

> From: Colin Ian King <colin.king@canonical.com>
>
> smatch detected a suspicious looking bitop condition:
>
> drivers/net/ethernet/cavium/liquidio/lio_main.c:2529
> handle_timestamp() warn: suspicious bitop condition
>
> (skb_shinfo(skb)->tx_flags | SKBTX_IN_PROGRESS is always non-zero,
> so the logic is definitely not correct. Use & to mask the correct
> bit.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Applied, thanks.

But this means one of the code paths was never tested...

\
 
 \ /
  Last update: 2016-02-13 12:41    [W:0.025 / U:0.384 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site