Messages in this thread | | | Date | Sat, 13 Feb 2016 06:06:40 -0500 (EST) | Subject | Re: [PATCH] net: cavium: liquidio: fix check for in progress flag | From | David Miller <> |
| |
From: Colin King <colin.king@canonical.com> Date: Fri, 5 Feb 2016 16:30:39 +0000
> From: Colin Ian King <colin.king@canonical.com> > > smatch detected a suspicious looking bitop condition: > > drivers/net/ethernet/cavium/liquidio/lio_main.c:2529 > handle_timestamp() warn: suspicious bitop condition > > (skb_shinfo(skb)->tx_flags | SKBTX_IN_PROGRESS is always non-zero, > so the logic is definitely not correct. Use & to mask the correct > bit. > > Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied, thanks.
But this means one of the code paths was never tested...
| |