Messages in this thread | | | From | Paul Gortmaker <> | Date | Sat, 13 Feb 2016 17:23:27 -0500 | Subject | Re: mm, compaction: fix build errors with kcompactd |
| |
On Tue, Feb 9, 2016 at 9:15 AM, Arnd Bergmann <arnd@arndb.de> wrote: > The newly added kcompactd code introduces multiple build errors: > > include/linux/compaction.h:91:12: error: 'kcompactd_run' defined but not used [-Werror=unused-function] > mm/compaction.c:1953:2: error: implicit declaration of function 'hotcpu_notifier' [-Werror=implicit-function-declaration] > > This marks the new empty wrapper functions as 'inline' to avoid unused-function warnings, > and includes linux/cpu.h to get the hotcpu_notifier declaration. > > Fixes: 8364acdfa45a ("mm, compaction: introduce kcompactd")
The 8364acdfa45a is a linux-next ID and changes on a daily basis, so you can't really use a "Fixes" here. It doesn't matter if akpm just squishes it into the original, but I thought I'd mention it for future reference.
P. ..
> Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > I stumbled over this while trying out the mmots patches today for an unrelated reason. > > diff --git a/include/linux/compaction.h b/include/linux/compaction.h > index 1367c0564d42..d7c8de583a23 100644 > --- a/include/linux/compaction.h > +++ b/include/linux/compaction.h > @@ -88,15 +88,15 @@ static inline bool compaction_deferred(struct zone *zone, int order) > return true;
[...]
| |