lkml.org 
[lkml]   [2016]   [Feb]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v1 4/6] power: cros_usbpd-charger: Add EC-based USB PD charger driver
On 10 February 2016 at 17:49, Lee Jones <lee.jones@linaro.org> wrote:
> On Fri, 05 Feb 2016, Tomeu Vizoso wrote:
>
>> From: Sameer Nanda <snanda@chromium.org>
>>
>> This driver exposes the charger functionality in the PD EC to userspace.
>>
>> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
>> Cc: Sameer Nanda <snanda@chromium.org>
>> Cc: Benson Leung <bleung@chromium.org>
>> Cc: Shawn Nematbakhsh <shawnn@chromium.org>
>> ---
>>
>> drivers/platform/chrome/cros_ec_proto.c | 37 ++
>> drivers/power/Kconfig | 10 +
>> drivers/power/Makefile | 1 +
>> drivers/power/cros_usbpd-charger.c | 907 ++++++++++++++++++++++++++++++++
>> include/linux/mfd/cros_ec.h | 28 +
>> include/linux/mfd/cros_ec_commands.h | 324 +++++++++++-
>> 6 files changed, 1302 insertions(+), 5 deletions(-)
>> create mode 100644 drivers/power/cros_usbpd-charger.c
>
> A 1300 line patch crossing 3 subsystems is not the way you should be
> submitting code. Please split these up into separate commits. The
> only time you should squash all this functionality into a single patch
> is to mitigate otherwise unavoidable build issues. I do not believe
> that's the case here.

Agreed, sorry about that.

Thanks,

Tomeu

\
 
 \ /
  Last update: 2016-02-12 12:21    [W:0.160 / U:1.440 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site