Messages in this thread | | | Date | Thu, 11 Feb 2016 09:17:31 +0000 | From | Lee Jones <> | Subject | Re: [PATCH V1] mfd: da9062: fix missing volatile registers in the core regmap_range volatile lists |
| |
On Wed, 10 Feb 2016, Opensource [Steve Twiss] wrote:
> > On 10 February 2016 16:56, Lee Jones wrote: > > > To: Opensource [Steve Twiss] > > Cc: LINUXKERNEL; David Dajun Chen; Support Opensource > > Subject: Re: [PATCH V1] mfd: da9062: fix missing volatile registers in the core > > regmap_range volatile lists > > > > On Mon, 01 Feb 2016, Steve Twiss wrote: > > > > > From: Steve Twiss <stwiss.opensource@diasemi.com> > > > > > > Add an updated set of registers listed in the core regmap_range volatile > > > ranges defined for the DA9062. > > > > > > These new registers contain bits that cannot be considered under the full > > > control of software. Under various conditions the hardware will set and/or > > > automatically clear bit(s) contained in these registers. > > > > > > When using a cached version of regmap, the volatility of these registers must > > > be identified otherwise the regmap operations may not ensure the registers > > > are explicitly altered. > > > > > > As well as updating the list of volatile registers, this change will fix a > > > corner case discovered in the DA9063 ONKEY which is used by the DA9062 core. > > > > > > In the ONKEY case, the CONTROL_B register is now listed as volatile in the > > > regmap_range because it contains the bit field NONKEY_LOCK. This bit can be > > > altered by hardware, in which case regmap must be notified of its ability > > > to be manpiulated outside of software control. > > > > > > Signed-off-by: Steve Twiss <stwiss.opensource@diasemi.com> > > > > Applied, thanks. > > Thanks. > Regards, > Steve
No need for thank yous. They're implied. ;)
[... and they just account for churn in my already very busy inbox].
-- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
| |