lkml.org 
[lkml]   [2016]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] regulator: ltc3589: Make IRQ optional
From
Date
Am Dienstag, den 09.02.2016, 21:14 +0100 schrieb Bernhard Walle:
> It's perfectly valid to use the LTC3589 without an interrupt pin
> connected to it. Currently, the driver probing fails when client->irq
> is 0 (which means "no interrupt"). Don't register the interrupt
> handler in that case but successfully finish the device probing instead.
>
> Signed-off-by: Bernhard Walle <bernhard@bwalle.de>

Acked-by: Philipp Zabel <p.zabel@pengutronix.de>

I suggest these small changes:

[...]
> @@ -520,12 +520,14 @@ static int ltc3589_probe(struct i2c_client *client,
> }
> }
>
> - ret = devm_request_threaded_irq(dev, client->irq, NULL, ltc3589_isr,
> - IRQF_TRIGGER_LOW | IRQF_ONESHOT,
> - client->name, ltc3589);
> - if (ret) {
> - dev_err(dev, "Failed to request IRQ: %d\n", ret);
> - return ret;
> + if (client->irq != 0) {

How about using
if (client->irq) {
here ...

> + ret = devm_request_threaded_irq(dev, client->irq, NULL, ltc3589_isr,

... and reflowing this ...

> + IRQF_TRIGGER_LOW | IRQF_ONESHOT,
> + client->name, ltc3589);
> + if (ret) {
> + dev_err(dev, "Failed to request IRQ %d: %d\n", client->irq, ret);

... and this long line.

regards
Philipp

\
 
 \ /
  Last update: 2016-02-10 11:01    [W:0.079 / U:0.632 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site