lkml.org 
[lkml]   [2016]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH V2 03/12] dtb: amd: Fix DMA ranges in device tree
Date
On Thursday 11 February 2016 04:13:50 Suravee Suthikulpanit wrote:
>
> On 2/9/16 21:57, Arnd Bergmann wrote:
> > On Monday 08 February 2016 11:59:08 Suravee Suthikulpanit wrote:
> >> From: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
> >>
> >> Fix DMA ranges of smb0 and pcie0 nodes in AMD Seattle SOC.
> >>
> >> Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
> >>
> >
> > This could use a changelog text to explain why it's broken and how the
> > fix works.
> >
> > Arnd
> >
>
> So, I have not experience the breakage. However, IIUC, the GICv2m MSI
> frame is also considered DMA-able. So, I think it should be included in
> the dma-range specified here. Please let me know if my assumption is
> incorrect. Otherwise, I will include more description in the commit log
> in my next rev.

No, I think this makes sense. Just put a more explanation into the changelog
when those things are not obvious from looking at the change.

Arnd

\
 
 \ /
  Last update: 2016-02-10 22:41    [W:0.048 / U:1.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site