Messages in this thread | | | Date | Wed, 10 Feb 2016 11:25:30 -0500 | From | Steven Rostedt <> | Subject | Re: [PATCH] printk: avoid livelock if another CPU printks continuously |
| |
On Wed, 10 Feb 2016 17:10:16 +0100 Petr Mladek <pmladek@suse.com> wrote:
> > Note, it's not that performance critical, and the loop only happens if > > someone else is adding to the console, which hopefully, should be rare. > > I probably used too strong words. It is possible that the performance > impact will not be critical. But the behavior is non-deterministic. > I think that the approach taken by Jack is more promising. > I mean the offloading of the console stuff to a workqueue.
My worry about that is that it never comes out. The point about printk, is that it should pretty much be guaranteed to print. If the system is dying, and we push it off to a work queue, and that workqueue never runs, then we lose critical data.
-- Steve
| |