lkml.org 
[lkml]   [2016]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 14/23] perf ui/stdio: Implement hierarchy output mode
On Wed, Feb 10, 2016 at 01:13:35PM +0100, Jiri Olsa wrote:
> On Fri, Feb 05, 2016 at 10:01:46PM +0900, Namhyung Kim wrote:
>
> SNIP
>
> > + printed += fprintf(fp, "%s\n", buf);
> > +
> > + if (symbol_conf.use_callchain && he->leaf) {
> > + u64 total = hists__total_period(hists);
> > +
> > + printed += hist_entry_callchain__fprintf(he, total, 0, fp);
> > + goto out;
> > + }
> > +
> > +out:
> > + return printed;
> > +}
> > +
> > static int hist_entry__fprintf(struct hist_entry *he, size_t size,
> > struct hists *hists,
> > char *bf, size_t bfsz, FILE *fp)
> > @@ -423,6 +488,13 @@ static int hist_entry__fprintf(struct hist_entry *he, size_t size,
> > if (size == 0 || size > bfsz)
> > size = hpp.size = bfsz;
> >
> > + if (symbol_conf.report_hierarchy) {
>
> it'd be great for review to have symbol_conf.report_hierarchy already
> present, so I could try it early in the patchset like with this change

I'm okay with it and that's what I do during the development. But
introducing the option prior to implementing all feature/UI caused
some troubles/crashes. So I put it after the implementation.

Thanks,
Namhyung

\
 
 \ /
  Last update: 2016-02-10 15:41    [W:0.167 / U:0.664 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site