lkml.org 
[lkml]   [2016]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V4 5/7] cpufreq: governor: No need to manage state machine now
On 10-02-16, 01:36, Rafael J. Wysocki wrote:
> > static int cpufreq_governor_stop(struct cpufreq_policy *policy)
> > {
> > - struct policy_dbs_info *policy_dbs = policy->governor_data;
> > -
> > - /* State should be equivalent to START */
> > - if (!policy_dbs->policy)
> > - return -EBUSY;
> > -
> > - gov_cancel_work(policy_dbs);
> > - policy_dbs->policy = NULL;
> > + gov_cancel_work(policy);
> >
> > return 0;
> > }
>
> So maybe we can call gov_cancel_work(policy) from
> cpufreq_governor_dbs() directly and get rid of this wrapper too?

I thought about it, but left it for consistency. It wouldn't hurt, the
compiler will anyway make it inline I believe.

--
viresh

\
 
 \ /
  Last update: 2016-02-10 07:21    [W:0.590 / U:0.672 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site