Messages in this thread | | | Date | Mon, 1 Feb 2016 09:38:27 -0800 | From | Brian Norris <> | Subject | Re: [PATCH 21/22] mtd: cs553x: Fix dependencies for !HAS_IOMEM archs |
| |
On Tue, Jan 26, 2016 at 02:58:19PM +0100, Richard Weinberger wrote: > Am 26.01.2016 um 12:00 schrieb Geert Uytterhoeven: > > On Mon, Jan 25, 2016 at 11:24 PM, Richard Weinberger <richard@nod.at> wrote: > >> Not every arch has io memory nor can this driver ever work > >> on UML/i386. > >> So, unbreak the build by fixing the dependencies. > >> > >> Signed-off-by: Richard Weinberger <richard@nod.at> > >> --- > >> drivers/mtd/nand/Kconfig | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig > >> index 545d82b..b253654 100644 > >> --- a/drivers/mtd/nand/Kconfig > >> +++ b/drivers/mtd/nand/Kconfig > >> @@ -311,6 +311,7 @@ config MTD_NAND_CAFE > >> config MTD_NAND_CS553X > >> tristate "NAND support for CS5535/CS5536 (AMD Geode companion chip)" > >> depends on X86_32 > >> + depends on !UML && HAS_IOMEM > > > > I don't think there's a need for the !UML dependency? > > Hence just "depends on X86_32 && HAS_IOMEM"? > > Strictly speaking this would work as HAS_IOMEM implies !UML. > The build error shows that it fails also because UML/i386 is x86_32 > but lacks some x86_32 stuff: >
[...]
> > Maybe a "depends on X86_32 && !UML" would make more sense. hmm?
That may be slightly clearer, but it's equivalent, so I've applied this patch as-is.
Thanks, Brian
| |