Messages in this thread | | | Subject | Re: [PATCH V2 net 03/20] net/ena: fix queues number calculation | From | Netanel Belgazal <> | Date | Mon, 5 Dec 2016 20:25:30 +0200 |
| |
On 12/05/2016 06:11 AM, Matt Wilson wrote: > On Sun, Dec 04, 2016 at 03:19:21PM +0200, Netanel Belgazal wrote: >> The ENA driver tries to open a queue per vCPU. >> To determine how many vCPUs the instance have it uses num_possible_cpus >> while it should have use num_online_cpus instead. > use () when referring to functions: num_possible_cpus(), num_online_cpus().
Ack > >> Signed-off-by: Netanel Belgazal <netanel@annapurnalabs.com> > Reviewed-by: Matt Wilson <msw@amazon.com> > >> --- >> drivers/net/ethernet/amazon/ena/ena_netdev.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c b/drivers/net/ethernet/amazon/ena/ena_netdev.c >> index 397c9bc..224302c 100644 >> --- a/drivers/net/ethernet/amazon/ena/ena_netdev.c >> +++ b/drivers/net/ethernet/amazon/ena/ena_netdev.c >> @@ -2667,7 +2667,7 @@ static int ena_calc_io_queue_num(struct pci_dev *pdev, >> io_sq_num = get_feat_ctx->max_queues.max_sq_num; >> } >> >> - io_queue_num = min_t(int, num_possible_cpus(), ENA_MAX_NUM_IO_QUEUES); >> + io_queue_num = min_t(int, num_online_cpus(), ENA_MAX_NUM_IO_QUEUES); >> io_queue_num = min_t(int, io_queue_num, io_sq_num); >> io_queue_num = min_t(int, io_queue_num, >> get_feat_ctx->max_queues.max_cq_num);
| |