Messages in this thread | | | Date | Fri, 23 Dec 2016 12:59:35 +0100 | From | Petr Mladek <> | Subject | Re: [PATCH] Fix usage of true and false as field names in struct taint_flag |
| |
On Thu 2016-12-22 13:56:38, Valdis Kletnieks wrote: > commit 7fd8329ba502ef76dd91db561c7aed696b2c7720 > Author: Petr Mladek <pmladek@suse.com> > Date: Wed Sep 21 13:47:22 2016 +0200 > > taint/module: Clean up global and module taint flags handling > > Contains this chunk:
Information about a past commits is usually writted using the following notation:
The commit 7fd8329ba502ef76dd ("taint/module: Clean up global and module taint flags handling") contains this chunk:
See also Documentation/process/submitting-patches.rst
> --- a/include/linux/kernel.h ^^^
This delimits a standard signature and the commit message below will be ignored by git. You should omit it in the commit message.
> > +struct taint_flag { > + char true; /* character printed when tainted */ > + char false; /* character printed when not tainted */ > + bool module; /* also show as a per-module taint flag */ > +}; > > and hilarity ensues when an out-of-tree module has this: > > # ifndef true > # define true (1) > # endif > # ifndef false > # define false (0) > # endif > > Change the field names to not shadow something likely to be used > by third-party modules. > > Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
The change itself looks fine. With the above fixes in the commit message, feel free to use
Reviewed-by: Petr Mladek <pmladek@suse.com>
Thanks for the fix.
Best Regards, Petr
| |