Messages in this thread | ![/](/images/icornerl.gif) | | From | "Jason A. Donenfeld" <> | Date | Thu, 22 Dec 2016 17:16:47 +0100 | Subject | Re: [kernel-hardening] Re: [PATCH v7 3/6] random: use SipHash in place of MD5 |
| |
Hi Ted,
On Thu, Dec 22, 2016 at 4:58 PM, Theodore Ts'o <tytso@mit.edu> wrote: > Can we do this as a separate series, please? At this point, it's a > completely separate change from a logical perspective, and we can take > in the change through the random.git tree. > > Changes that touch files that are normally changed in several > different git trees leads to the potential for merge conflicts during > the linux-next integration and merge window processes. Which is why > it's generally best to try to isolate changes as much as possible.
Sure, I can separate things out.
Could you offer a bit of advice on how to manage dependencies between patchsets during merge windows? I'm a bit new to the process.
Specifically, we how have 4 parts: 1. add siphash, and use it for some networking code. to: david miller's net-next 2. convert char/random to use siphash. to: ted ts'o's random-next 3. move lib/md5.c to static function in crypto/md5.c, remove entry inside of linux/cryptohash.h. to: ??'s ??-next 4. move lib/halfmd4.c to static function in fs/ext/hash.c, remove entry inside of linux/cryptohash.c. to: td ts'o's ext-next
Problem: 2 depends on 1, 3 depends on 1 & 2. But this can be simplified into 3 parts:
1. add siphash, and use it for some networking code. to: david miller's net-next 2. convert char/random to use siphash, move lib/md5.c to static function in crypto/md5.c, remove entry inside of linux/cryptohash.h. to: ted ts'o's random-next 3. move lib/halfmd4.c to static function in fs/ext/hash.c, remove entry inside of linux/cryptohash.c. to: td ts'o's ext-next
Problem: 2 depends on 1. Is that okay with you?
Also, would you like me to merge (3) and (2) of the second list into one series for you?
Jason
| ![\](/images/icornerr.gif) |