Messages in this thread | | | Subject | Re: [PATCH 2/3] xen: return xenstore command failures via response instead of rc | From | Boris Ostrovsky <> | Date | Thu, 22 Dec 2016 11:00:46 -0500 |
| |
On 12/22/2016 10:55 AM, Juergen Gross wrote: > On 22/12/16 16:49, Boris Ostrovsky wrote: >> On 12/22/2016 02:19 AM, Juergen Gross wrote: >>> When the xenbus driver does some special handling for a Xenstore >>> command any error condition related to the command should be returned >>> via an error response instead of letting the related write operation >>> fail. Otherwise the user land handler might take wrong decisions >>> assuming the connection to Xenstore is broken. >> Do we expect the user to always read the reply if no error code was >> returned? > Absolutely, yes. This is how error reporting of Xenstore is > working.
Oh, right --- I was thinking about the string that you are passing back but not the message type (XS_ERROR).
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
| |