Messages in this thread | ![/](/images/icornerl.gif) | | From | (Eric W. Biederman) | Date | Thu, 22 Dec 2016 23:19:17 +1300 | Subject | Re: [PATCH v4 1/3] perf: add PERF_RECORD_NAMESPACES to include namespaces related info |
| |
Peter Zijlstra <peterz@infradead.org> writes:
> On Thu, Dec 22, 2016 at 08:21:23PM +1300, Eric W. Biederman wrote: >> >> And please make the array the last item in the structure so that >> expanding or contracting it does not affect the ability to read the rest >> of the structure. > > Sorry, sample_id must be last, because hysterical crud :/ > > (basically because that was the only way to add a field to records like > PERF_RECORD_MMAP which used the record length to determine the > filename[] length, yes I know, we won't ever do that again).
Why does historical crud need to affect new records?
Totally confused. This looks like a major mess.
Eric
| ![\](/images/icornerr.gif) |