lkml.org 
[lkml]   [2016]   [Dec]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] clk: uniphier: Fix build with gcc-4.4.
Hi Vinson,

2016-12-03 9:37 GMT+09:00 Vinson Lee <vlee@freedesktop.org>:
> gcc-4.4 has issues with anonymous unions in initializers.
>
> CC drivers/clk/uniphier/clk-uniphier-sys.o
> drivers/clk/uniphier/clk-uniphier-sys.c:45: error: unknown field ‘factor’ specified in initializer
>
> Fixes: 1574d5722636 ("clk: uniphier: remove unneeded member name for union")
> Signed-off-by: Vinson Lee <vlee@freedesktop.org>


This driver has COMPILE_TEST option, but kbuild test robot
did not mention about this.



This is a bad way of fixing, I think.
(what if a new member is inserted before the union in the future?)

Rather, please revert the bad commit.


> .name = "sd" #ch "-sel", \
> .type = UNIPHIER_CLK_TYPE_MUX, \
> .idx = -1, \
> - .mux = { \
> + { .mux = { \
> .parent_names = { \
> "sd-44m", \
> "sd-33m", \
> @@ -63,7 +63,7 @@
> 0x00001200, \
> 0x00001300, \
> }, \
> - }, \
> + } }, \
> }, \


No, please do not do this.






--
Best Regards
Masahiro Yamada

\
 
 \ /
  Last update: 2016-12-03 02:25    [W:0.101 / U:0.844 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site