lkml.org 
[lkml]   [2016]   [Dec]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/6] fscrypt: Release fscrypt context on in-place encryption
On Thu, Dec 01, 2016 at 11:14:54PM +0100, Richard Weinberger wrote:
> From: David Gstir <david@sigma-star.at>
>
> In case of in-place encryption ctx must be released right away.
> Otherwise ctx is never freed.
>

I didn't notice this before, but the fscrypt_ctx isn't actually used at all in
the "own pages" crypto case. So there's really no need to allocate one. How
about we just handle the "own pages" case at the beginning of
fscrypt_encrypt_page():

if (inode->i_sb->s_cop->flags & FS_CFLG_OWN_PAGES) {
err = do_page_crypto(inode, FS_ENCRYPT, lblk_num, page, page,
len, offs, gfp_flags);
if (err)
return ERR_PTR(err);
return page;
}

(and the rest essentially the same as it used to be)

Eric

\
 
 \ /
  Last update: 2016-12-02 09:13    [W:0.116 / U:0.696 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site